[PATCH] common: Kconfig: Fix CMD_BMP/BMP dependency

Samuel Dionne-Riel samuel at dionne-riel.com
Mon Jul 10 01:18:10 CEST 2023

Using `default y` will not select BMP when CMD_BMP has been enabled, if
it was already configured.

By using `select`, if `CMD_BMP` is turned on, it will force the presence
of `BMP`.

Fixes: 072b0e16c482114d242580dd7a3197db5966705f
Signed-off-by: Samuel Dionne-Riel <samuel at dionne-riel.com>
 cmd/Kconfig    | 1 +
 common/Kconfig | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/cmd/Kconfig b/cmd/Kconfig
index 02e54f1e50..94c54b2359 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -1988,6 +1988,7 @@ config CMD_2048
 config CMD_BMP
 	bool "Enable 'bmp' command"
 	depends on VIDEO
+	select BMP
 	  This provides a way to obtain information about a BMP-format image
 	  and to display it. BMP (which presumably stands for BitMaP) is a
diff --git a/common/Kconfig b/common/Kconfig
index bbabadb35e..d0117e3dc8 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -1157,7 +1157,7 @@ config IO_TRACE
 config BMP
 	bool "Enable bmp image display"
-	default y if CMD_BMP
+	default n
 	  Enable bmp functions to display bmp image and get bmp info.

More information about the U-Boot mailing list