[PATCH] Makefile: Use sort shortopts

Mark Kettenis mark.kettenis at xs4all.nl
Thu Jul 20 15:45:31 CEST 2023


> From: Marek Vasut <marex at denx.de>
> Date: Thu, 20 Jul 2023 14:50:42 +0200
> 
> POSIX does not defined longopts for sort, use shortops
> for even more compatibility.

Even though OpenBSD's sort does implement the long options this is
still good to have!

Reviewed-by: Mark Kettenis <kettenis at openbsd.org>

> Fixes: cc5a490cf465 ("Makefile: Sort u-boot-initial-env output")
> Reported-by: Milan P. Stanić <mps at arvanta.net>
> Signed-off-by: Marek Vasut <marex at denx.de>
> ---
> Cc: Christoph Niedermaier <cniedermaier at dh-electronics.com>
> Cc: Marek Behún <marek.behun at nic.cz>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Stefano Babic <sbabic at denx.de>
> Cc: u-boot at dh-electronics.com
> Cc: u-boot at lists.denx.de
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 87f9fc786e8..5fc16b3b1f1 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2444,7 +2444,7 @@ quiet_cmd_genenv = GENENV  $@
>  cmd_genenv = \
>  	$(objtree)/tools/printinitialenv | \
>  	sed -e '/^\s*$$/d' | \
> -	sort --field-separator='=' -k1,1 --stable -o $@
> +	sort -t '=' -k 1,1 -s -o $@
>  
>  u-boot-initial-env: $(env_h) FORCE
>  	$(Q)$(MAKE) $(build)=tools $(objtree)/tools/printinitialenv
> -- 
> 2.40.1
> 
> 


More information about the U-Boot mailing list