[PATCH] Makefile: Use sort shortopts

Milan P. Stanić mps at arvanta.net
Thu Jul 20 18:28:51 CEST 2023


On Thu, 2023-07-20 at 14:50, Marek Vasut wrote:
> POSIX does not defined longopts for sort, use shortops
> for even more compatibility.
> 
> Fixes: cc5a490cf465 ("Makefile: Sort u-boot-initial-env output")
> Reported-by: Milan P. Stanić <mps at arvanta.net>
> Signed-off-by: Marek Vasut <marex at denx.de>

Tested-by: Milan P. Stanić <mps at arvanta.net>

small note: single quotes are not needed aroud = (equal sign)

> ---
> Cc: Christoph Niedermaier <cniedermaier at dh-electronics.com>
> Cc: Marek Behún <marek.behun at nic.cz>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Stefano Babic <sbabic at denx.de>
> Cc: u-boot at dh-electronics.com
> Cc: u-boot at lists.denx.de
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 87f9fc786e8..5fc16b3b1f1 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2444,7 +2444,7 @@ quiet_cmd_genenv = GENENV  $@
>  cmd_genenv = \
>  	$(objtree)/tools/printinitialenv | \
>  	sed -e '/^\s*$$/d' | \
> -	sort --field-separator='=' -k1,1 --stable -o $@
> +	sort -t '=' -k 1,1 -s -o $@
>  
>  u-boot-initial-env: $(env_h) FORCE
>  	$(Q)$(MAKE) $(build)=tools $(objtree)/tools/printinitialenv
> -- 
> 2.40.1
> 


More information about the U-Boot mailing list