[PATCH 1/3] trace: Use 64bit variable for start and len

Simon Glass sjg at chromium.org
Tue Sep 12 21:26:47 CEST 2023


Hi Michal,

On Mon, 11 Sept 2023 at 06:32, Michal Simek <michal.simek at amd.com> wrote:
>
> tputq() requires variables to have 64bit width that's why make them 64bit
> to clean alignment requirement.
>
> Signed-off-by: Michal Simek <michal.simek at amd.com>
> ---
>
>  tools/proftool.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg at chromium.org>

I would have thought that 'unsigned long' is enough on a 64-bit
machines? Are you running on 32-bit?

>
> diff --git a/tools/proftool.c b/tools/proftool.c
> index 101bcb63334e..869a2a32c510 100644
> --- a/tools/proftool.c
> +++ b/tools/proftool.c
> @@ -1493,7 +1493,8 @@ static int write_pages(struct twriter *tw, enum out_format_t out_format,
>  static int write_flyrecord(struct twriter *tw, enum out_format_t out_format,
>                            int *missing_countp, int *skip_countp)
>  {
> -       int start, ret, len;
> +       unsigned long long start, len;
> +       int ret;
>         FILE *fout = tw->fout;
>         char str[200];
>
> --
> 2.36.1
>

Regards,
Simon


More information about the U-Boot mailing list