[PATCH 1/3] trace: Use 64bit variable for start and len

Michal Simek michal.simek at amd.com
Thu Sep 14 16:54:44 CEST 2023



On 9/12/23 21:26, Simon Glass wrote:
> Hi Michal,
> 
> On Mon, 11 Sept 2023 at 06:32, Michal Simek <michal.simek at amd.com> wrote:
>>
>> tputq() requires variables to have 64bit width that's why make them 64bit
>> to clean alignment requirement.
>>
>> Signed-off-by: Michal Simek <michal.simek at amd.com>
>> ---
>>
>>   tools/proftool.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> I would have thought that 'unsigned long' is enough on a 64-bit
> machines? Are you running on 32-bit?

I have done it for better code understanding. U-Boot is small and 32bit var is 
big enough. 64bit is more then enough but spec allocates for it 128bits that's 
why it is easier to read that you are actually putting there the whole 128bits.

M



More information about the U-Boot mailing list