[PATCH 07/21] Revert "net: wget: Support retransmission a dropped packet"

[Simon Glass]

+Ying-Chun Liu (PaulLiu) <paul.liu at linaro.org>

Hi Yasuharu,

On Sat, 10 Aug 2024 at 20:48, Yasuharu Shibata
<yasuharu.shibata at gmail.com> wrote:
>
> Dear Simon,
>
> Could you inform me how the wget test was broken?
> As I explained in the commit log, I fixed the bug in specific conditions.
> Without the details of how the break happened,
> it is difficult to find a proper patch.
>
> Best regards,
> Yasuharu Shibata

Yes, I should have mentioned that. It is test/cmd/wget.c - see also [1].

This is a good run:
Test: net_test_wget: wget.c
HTTP/1.1 200 OK
Packets received 5, Transfer Successful
Bytes transferred = 32 (20 hex)
md5 for 00020000 ... 0002001f ==> 234af48e94b0085060249ecb5942ab57
Failures: 0

With your patch it hangs:

Test: net_test_wget: wget.c
HTTP/1.1 200 OKT

>
> On Sun, 11 Aug 2024 at 05:52, Simon Glass <sjg at chromium.org> wrote:
> >
> > This breaks the wget tests, so revert it until a proper fix can be
> > figured out.
> >
> > This reverts commit cab7867cff33f9c21025102ea9ca3b26e362fb52.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> >
> >  net/wget.c | 16 +++++-----------
> >  1 file changed, 5 insertions(+), 11 deletions(-)

[..]

[1] https://docs.u-boot.org/en/latest/develop/testing.html