[PATCH 07/21] Revert "net: wget: Support retransmission a dropped packet"

Tom Rini trini at konsulko.com
Mon Aug 12 20:46:15 CEST 2024


On Sun, Aug 11, 2024 at 08:50:18AM -0600, Simon Glass wrote:
> +Ying-Chun Liu (PaulLiu) <paul.liu at linaro.org>
> 
> Hi Yasuharu,
> 
> On Sat, 10 Aug 2024 at 20:48, Yasuharu Shibata
> <yasuharu.shibata at gmail.com> wrote:
> >
> > Dear Simon,
> >
> > Could you inform me how the wget test was broken?
> > As I explained in the commit log, I fixed the bug in specific conditions.
> > Without the details of how the break happened,
> > it is difficult to find a proper patch.
> >
> > Best regards,
> > Yasuharu Shibata
> 
> Yes, I should have mentioned that. It is test/cmd/wget.c - see also [1].
> 
> This is a good run:
> Test: net_test_wget: wget.c
> HTTP/1.1 200 OK
> Packets received 5, Transfer Successful
> Bytes transferred = 32 (20 hex)
> md5 for 00020000 ... 0002001f ==> 234af48e94b0085060249ecb5942ab57
> Failures: 0
> 
> With your patch it hangs:
> 
> Test: net_test_wget: wget.c
> HTTP/1.1 200 OKT

Can you please figure out what's going on with the sandbox test then?
The change in question fixes wget support on real hardware, and also the
other wget tests (as part of the lwIP series) work fine as well. This
seems like something specific to that test.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20240812/7b5bf95d/attachment.sig>


More information about the U-Boot mailing list