[PATCH v3] driver: pwm: pwm-imx: fix probing on imx6

[Heiko Schocher]

Hello Tom,

On 14.08.24 16:17, Tom Rini wrote:
> On Wed, Aug 14, 2024 at 02:10:27PM +0200, Heiko Schocher wrote:
> 
>> U-Boot 2024.07 drops on aristainetos2 board the following
>> warning:
>>
>> 	Failed to enable per_clk
>>
>> and bootlogo is not seen on LVDS display.
>>
>> This patch uses old behaviour for systems without clock framework
>> if CONFIG_CLK is not enabled.
>>
>> Fixes: bfc778cb93a3 ("driver: pwm: pwm-imx: get and enable per/ipg clock using dm")
>> Fixes: 4eea76574062 ("pwm: imx: Remove unused references to CONFIG_IMX6_PWM_PER_CLK")
>>
>> Signed-off-by: Heiko Schocher <hs at denx.de>
> 
> I really do not like this and would like to see the clock migration also
> enabled / completed on these platforms. Then we can also go and rip out
> the non-DM_PWM code here.

Yes, valid argument, I also thought about this. Anyone working on
this part?

Until this work is not done, this patch is in my eyes a bugfix...

Just enabled CONFIG_CLK and CONFIG_CLK_IMX6Q on the aristainetos2
board and get [1] (as I also have there CONFIG_VIDEO_IPUV3=y)

Uff... yes, there are such functions in drivers/video/imx/ipu_common.c

:-(

and even worser "struct clk" is defined in

drivers/video/imx/ipu.h#L22
and
include/clk.h#L63

completly different ... so this is not a fast job... I fear...

bye,
Heiko

[1]
| arm-poky-linux-gnueabi-ld.bfd: drivers/video/imx/ipu_common.o: in function `clk_enable':
| /usr/src/debug/u-boot/aristainetos2_2024.07/drivers/video/imx/ipu_common.c:93: multiple definition 
of `clk_enable'; 
drivers/clk/clk-uclass.o:/usr/src/debug/u-boot/aristainetos2_2024.07/drivers/clk/clk-uclass.c:611: 
first defined here
| arm-poky-linux-gnueabi-ld.bfd: drivers/video/imx/ipu_common.o: in function `clk_disable':
| /usr/src/debug/u-boot/aristainetos2_2024.07/drivers/video/imx/ipu_common.c:102: multiple 
definition of `clk_disable'; 
drivers/clk/clk-uclass.o:/usr/src/debug/u-boot/aristainetos2_2024.07/drivers/clk/clk-uclass.c:672: 
first defined here
| arm-poky-linux-gnueabi-ld.bfd: drivers/video/imx/ipu_common.o: in function `clk_get_rate':
| /usr/src/debug/u-boot/aristainetos2_2024.07/drivers/video/imx/ipu_common.c:120: multiple 
definition of `clk_get_rate'; 
drivers/clk/clk-uclass.o:/usr/src/debug/u-boot/aristainetos2_2024.07/include/clk.h:645: first 
defined here
| arm-poky-linux-gnueabi-ld.bfd: drivers/video/imx/ipu_common.o: in function `clk_get_parent':
| /usr/src/debug/u-boot/aristainetos2_2024.07/drivers/video/imx/ipu_common.c:128: multiple 
definition of `clk_get_parent'; 
drivers/clk/clk-uclass.o:/usr/src/debug/u-boot/aristainetos2_2024.07/drivers/clk/clk-uclass.c:478: 
first defined here
| arm-poky-linux-gnueabi-ld.bfd: drivers/video/imx/ipu_common.o: in function `clk_set_rate':
| /usr/src/debug/u-boot/aristainetos2_2024.07/drivers/video/imx/ipu_common.c:135: multiple 
definition of `clk_set_rate'; 
drivers/clk/clk-uclass.o:/usr/src/debug/u-boot/aristainetos2_2024.07/drivers/clk/clk-uclass.c:565: 
first defined here
| arm-poky-linux-gnueabi-ld.bfd: drivers/video/imx/ipu_common.o: in function `clk_round_rate':
| /usr/src/debug/u-boot/aristainetos2_2024.07/drivers/video/imx/ipu_common.c:147: multiple 
definition of `clk_round_rate'; 
drivers/clk/clk-uclass.o:/usr/src/debug/u-boot/aristainetos2_2024.07/include/clk.h:645: first 
defined here
| arm-poky-linux-gnueabi-ld.bfd: drivers/video/imx/ipu_common.o: in function `clk_set_parent':
| /usr/src/debug/u-boot/aristainetos2_2024.07/drivers/video/imx/ipu_common.c:156: multiple 
definition of `clk_set_parent'; 
drivers/clk/clk-uclass.o:/usr/src/debug/u-boot/aristainetos2_2024.07/drivers/clk/clk-uclass.c:586: 
first defined here

-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de