[PATCH v3] driver: pwm: pwm-imx: fix probing on imx6

[Tom Rini]

On Thu, Aug 15, 2024 at 01:17:02PM +0200, Heiko Schocher wrote:
> Hello Tom,
> 
> On 14.08.24 16:17, Tom Rini wrote:
> > On Wed, Aug 14, 2024 at 02:10:27PM +0200, Heiko Schocher wrote:
> > 
> > > U-Boot 2024.07 drops on aristainetos2 board the following
> > > warning:
> > > 
> > > 	Failed to enable per_clk
> > > 
> > > and bootlogo is not seen on LVDS display.
> > > 
> > > This patch uses old behaviour for systems without clock framework
> > > if CONFIG_CLK is not enabled.
> > > 
> > > Fixes: bfc778cb93a3 ("driver: pwm: pwm-imx: get and enable per/ipg clock using dm")
> > > Fixes: 4eea76574062 ("pwm: imx: Remove unused references to CONFIG_IMX6_PWM_PER_CLK")
> > > 
> > > Signed-off-by: Heiko Schocher <hs at denx.de>
> > 
> > I really do not like this and would like to see the clock migration also
> > enabled / completed on these platforms. Then we can also go and rip out
> > the non-DM_PWM code here.
> 
> Yes, valid argument, I also thought about this. Anyone working on
> this part?
> 
> Until this work is not done, this patch is in my eyes a bugfix...
> 
> Just enabled CONFIG_CLK and CONFIG_CLK_IMX6Q on the aristainetos2
> board and get [1] (as I also have there CONFIG_VIDEO_IPUV3=y)
> 
> Uff... yes, there are such functions in drivers/video/imx/ipu_common.c
> 
> :-(
> 
> and even worser "struct clk" is defined in
> 
> drivers/video/imx/ipu.h#L22
> and
> include/clk.h#L63
> 
> completly different ... so this is not a fast job... I fear...

Yeah, that looks like lots of legacy code that needs to be updated. Is
someone going to update it? If not, perhaps we should be removing it,
and boards, instead of adding work-arounds for lack of migration.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20240815/0b560b62/attachment.sig>