[PATCH] cmd: eeprom: Fix config dependency

Ivan Orlov ivan.orlov at codethink.co.uk
Fri Feb 23 15:08:03 CET 2024


On 22/02/2024 17:46, Tom Rini wrote:
> On Mon, Feb 19, 2024 at 06:18:38PM +0000, Ivan Orlov wrote:
> 
>> We should have CONFIG_DM_I2C or CONFIG_(SPL_)SYS_I2C_LEGACY enabled in
>> order for `cmd/eeprom.c` to compile as it depends on the i2c functions
>> which are not compiled otherwise. Update the Kconfig entry for the
>> 'eeprom' command correspondingly.
>>
>> Signed-off-by: Ivan Orlov <ivan.orlov at codethink.co.uk>
>> ---
>>   cmd/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/cmd/Kconfig b/cmd/Kconfig
>> index a86b570517..6a1a64566c 100644
>> --- a/cmd/Kconfig
>> +++ b/cmd/Kconfig
>> @@ -740,6 +740,7 @@ config CRC32_VERIFY
>>   
>>   config CMD_EEPROM
>>   	bool "eeprom - EEPROM subsystem"
>> +	depends on DM_I2C || SYS_I2C_LEGACY || SPL_SYS_I2C_LEGACY
> 
> You cannot enable commands in SPL, so SPL_SYS_I2C_LEGACY doesn't make
> sense here.
> 

Ah, alright, I'll fix it and send the V2. Thank you for the review!
-- 
Kind regards,
Ivan Orlov



More information about the U-Boot mailing list