[PATCH 08/10] board: beagle: beagleboneai64: Set fdtfile from C code instead of findfdt script

Nishanth Menon nm at ti.com
Tue Jan 9 15:20:54 CET 2024


On 20:24-20240108, Jon Humphreys wrote:
> Nishanth Menon <nm at ti.com> writes:
> 
> > Stop using the findfdt script and switch to setting the fdtfile from C
> > code.
> >
> > While at this, replace findfdt in environment with a warning as it is
> > no longer needed
> >
> > Signed-off-by: Nishanth Menon <nm at ti.com>
> > ---
> >  board/beagle/beagleboneai64/beagleboneai64.c   | 14 ++++++++++++++
> >  board/beagle/beagleboneai64/beagleboneai64.env |  1 -
> >  configs/j721e_beagleboneai64_a72_defconfig     |  3 ++-
> >  3 files changed, 16 insertions(+), 2 deletions(-)
> >
> > diff --git a/board/beagle/beagleboneai64/beagleboneai64.c b/board/beagle/beagleboneai64/beagleboneai64.c
> > index c8c1c78ae5a2..1982f738b04e 100644
> > --- a/board/beagle/beagleboneai64/beagleboneai64.c
> > +++ b/board/beagle/beagleboneai64/beagleboneai64.c
> > @@ -28,3 +28,17 @@ int dram_init_banksize(void)
> >  {
> >  	return fdtdec_setup_memory_banksize();
> >  }
> > +
> > +#ifdef CONFIG_BOARD_LATE_INIT
> > +int board_late_init(void)
> > +{
> > +	char fdtfile[50];
> > +
> > +	snprintf(fdtfile, sizeof(fdtfile), "%s/%s.dtb",
> > +		 CONFIG_TI_EVM_FDT_FOLDER_PATH, CONFIG_DEFAULT_DEVICE_TREE);
> 
> This would set the board to using the control DT, not boot DT.  Is that
> what you meant?

control DT file name. not the content.

> But anyway, why not just hard code the FDT path/name here since there is
> only one for this board?  I don't see the value in the extra logic of
> using the config values (or having a fdt_map).  (Same for beagleplay)

because there are potentially variants being privately discussed for both the
platforms - though the timelines are unknown at this point. This will
allow fragments to replace the DEFAULT_DEVICE_TREE to the variant and
rest of the logic will *just work*.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D


More information about the U-Boot mailing list