[PATCH] arm: The CHIP DIP SCAN option should not be displayed in other mach

[黄利亚]

Hi,


That's the first question.Now I see this option in menuconfig, it should not be available on other models.I used the following command:
    export CROSS_COMPILE=arm-none-eabi- ARCH=arm
    make stm32h750-art-pi_defconfig
    make menuconfig
    ARM architecture  --->Enable DIPs detection for CHIP board (NEW)


So I implemented this patch to fix it.
But I find that the root cause is that this 
config is not included in if ARCH_SUNXI. 


This is the second problem.I tried to include it, 
but got a compiler error.

diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
index ba1b1541437..b467ab098c0 100644
--- a/arch/arm/mach-sunxi/Kconfig
+++ b/arch/arm/mach-sunxi/Kconfig
@@ -1133,8 +1133,6 @@ config BLUETOOTH_DT_DEVICE_FIXUP
 
 source "board/sunxi/Kconfig"
 
-endif
-
 config CHIP_DIP_SCAN
 	bool "Enable DIPs detection for CHIP board"
 	select SUPPORT_EXTENSION_SCAN
@@ -1143,3 +1141,6 @@ config CHIP_DIP_SCAN
 	select W1_EEPROM
 	select W1_EEPROM_DS24XXX
 	select CMD_EXTENSION
+
+
+endif



The error message for running make menuconfig is as follows:
arch/arm/mach-sunxi/Kconfig:1146: 'endif' in different file than 'if'
arch/arm/mach-sunxi/Kconfig:1: location of the 'if'
arch/arm/Kconfig:2417: 'endmenu' in different file than 'menu'
arch/arm/mach-sunxi/Kconfig:1: location of the 'menu


Cheers,
LiYa


------------------ Original ------------------
From:                                                                                                                        "Andre Przywara"                                                                                    <andre.przywara at arm.com>;
Date: Tue, Jan 28, 2025 11:55 PM
To: "黄利亚"<1425075683 at qq.com>;
Cc: "Chris Morgan"<macromorgan at hotmail.com>;"Jagan Teki"<jagan at amarulasolutions.com>;"Jernej Skrabec"<jernej.skrabec at gmail.com>;"Maksim Kiselev"<bigunclemax at gmail.com>;"Michael Walle"<mwalle at kernel.org>;"Samuel Holland"<samuel at sholland.org>;"Simon Glass"<sjg at chromium.org>;"SumitGarg"<sumit.garg at linaro.org>;"Tom Rini"<trini at konsulko.com>;"u-boot"<u-boot at lists.denx.de>;
Subject: Re: [PATCH] arm: The CHIP DIP SCAN option should not be displayed in other mach



On Tue, 28 Jan 2025 21:37:37 +0800
1425075683 at qq.com wrote:

Hi,

> From: Liya Huang <1425075683 at qq.com>
> 
> When I use mach STM32,
> menuconfig sees this option; It bothers me.
> I observed that the root cause was that the
> option was not included in the endif,
> but when I tried to fix it, an error occurred.

Can you say what the error is, exactly?
Because you are right, it should be before the endif.
I moved that, and compiled it for all Allwinner boards, which worked.
So what is the problem there, exactly?

Cheers,
Andre

> I didn't find a solution. Only deponds can be used for hiding.
> 
> Signed-off-by: Liya Huang <1425075683 at qq.com>
> ---
> 
>  arch/arm/mach-sunxi/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
> index ba1b1541437..48dd1e68363 100644
> --- a/arch/arm/mach-sunxi/Kconfig
> +++ b/arch/arm/mach-sunxi/Kconfig
> @@ -1137,6 +1137,7 @@ endif
>  
>  config CHIP_DIP_SCAN
>  	bool "Enable DIPs detection for CHIP board"
> +	depends on ARCH_SUNXI
>  	select SUPPORT_EXTENSION_SCAN
>  	select W1
>  	select W1_GPIO