[PATCH] usb: dwc3: gadget: Fix match_ep callback for NXP UUU tool
Marek Vasut
marex at denx.de
Mon Mar 24 15:36:52 CET 2025
On 3/24/25 3:16 PM, Francesco Dolcini wrote:
> On Mon, Mar 24, 2025 at 02:53:23PM +0100, Marek Vasut wrote:
>> On 3/24/25 1:30 PM, Francesco Dolcini wrote:
>>> On Mon, Mar 24, 2025 at 09:26:03AM +0100, Mattijs Korpershoek wrote:
>>>> Hi Francesco,
>>>>
>>>> On lun., mars 24, 2025 at 09:03, Francesco Dolcini <francesco at dolcini.it> wrote:
>>>>
>>>>> Hello Mattijs, Marek
>>>>>
>>>>> On Thu, Mar 20, 2025 at 10:47:02AM +0100, Mattijs Korpershoek wrote:
>>>>>> On mer., mars 19, 2025 at 23:07, Marek Vasut <marex at denx.de> wrote:
>>>>>>
>>>>>>> The UUU tool excepts the interrupt-in endpoint to be ep1in, otherwise
>>>>>>> it crashes. This is a result of the previous hard-coded EP setup in
>>>>>>> drivers/usb/gadget/epautoconf.c which did special-case EP allocation
>>>>>>> for SPL builds, and which was since converted to this callback, but
>>>>>>> without the special-case EP allocation in SPL part.
>>>>>>>
>>>>>>> This reinstates the SPL part in an isolated manner, only for NXP iMX
>>>>>>> SoCs, only for SPL builds, and only for the ep1in interrupt-in endpoint.
>>>>>
>>>>> UUU can (and in our case is) used also on non-NXP i.MX platforms.
>>>>> What should we do?
>>>>
>>>> Do reproduce the problem (UUU tool crashes) on those platforms with
>>>> recent U-Boot versions (v2024.10+) ?
>>>
>>> Not tested, my comment is purely based on the code and the commit message.
>>> Older U-Boot versions (up to v2024.04, included) are working fine, with UUU used
>>> with TI K3 SoCs (AM69, AM62, AM62P).
>> Are you talking about the NXP UUU ?
>
> yes, it works just fine on not-NXP SoC.
Then please test if it still works, and if not, this patch needs to be
expanded to cover TI ... or apply unconditionally in SPL (sigh).
More information about the U-Boot
mailing list