[PATCH 1/3] rockchip: i2c: fix incorrect STOP flag for the interrupt enable register

[Heiko Schocher]

Hello Quentin,

On 07.11.25 12:39, Quentin Schulz wrote:
> From: Quentin Schulz <quentin.schulz at cherry.de>
> 
> I2C_CON_STOP is a flag to be used for the con register, where it is bit
> 4 to send the STOP condition.
> 
> To enable the interrupt the controller sends to tell it's finished
> sending the STOP condition, it's the ien register at bit 5.
> 
> Let's use the proper offset.
> 
> My hunch is that enabling the interrupt is useless as the interrupt
> status register is always up-to-date and enabling the interrupt is just
> so that the interrupt is available via the GIC. However, U-Boot has no
> interrupt support and the logic was working well before this patch. This
> is just so people aren't side-tracked when debugging I2C issues on
> Rockchip by checking all writes are proper.
> 
> Fixes: 3437469985df ("rockchip: Add I2C driver")
> Signed-off-by: Quentin Schulz <quentin.schulz at cherry.de>
> ---
>   drivers/i2c/rk_i2c.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Heiko Schocher <hs at nabladev.com>

The series is delegated to Kever Yang, so it is fine for me,
if he picks up the series!

bye,
Heiko

-- 
Nabla Software Engineering
HRB 40522 Augsburg
Phone: +49 821 45592596
E-Mail: office at nabladev.com
Geschäftsführer : Stefano Babic