[PATCH v2 2/2] mtd: rawnand: atmel: atmel_pmecc_create: Remove unused code

[Eugen Hristev]

On 11/10/25 17:25, Alexander Dahl wrote:
> Hello,
> 
> Am Fri, Nov 07, 2025 at 04:02:24PM +0100 schrieb Zixun LI:
>> "timing" and "timing_res_idx" are unused and not exist in Linux driver,
>> let's remove them.
>>
>> Signed-off-by: Zixun LI <admin at hifiphile.com>
>> ---
>>  drivers/mtd/nand/raw/atmel/pmecc.c | 7 ++-----
>>  drivers/mtd/nand/raw/atmel/pmecc.h | 1 -
>>  2 files changed, 2 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/mtd/nand/raw/atmel/pmecc.c b/drivers/mtd/nand/raw/atmel/pmecc.c
>> index 7c4e9bd5f9967b119239adf2b39e683ea62b71fd..1acaa5d0e0783f11be8236ad12b42540ca530a5b 100644
>> --- a/drivers/mtd/nand/raw/atmel/pmecc.c
>> +++ b/drivers/mtd/nand/raw/atmel/pmecc.c
>> @@ -820,8 +820,7 @@ EXPORT_SYMBOL_GPL(atmel_pmecc_wait_rdy);
>>  static struct atmel_pmecc *
>>  atmel_pmecc_create(struct udevice *dev,
>>  		   const struct atmel_pmecc_caps *caps,
>> -		   int pmecc_res_idx, int errloc_res_idx,
>> -		   int timing_res_idx)
>> +		   int pmecc_res_idx, int errloc_res_idx)
>>  {
>>  	struct atmel_pmecc *pmecc;
>>  	struct resource res;
>> @@ -839,8 +838,6 @@ atmel_pmecc_create(struct udevice *dev,
>>  	ofnode_read_resource(dev->node_, 1, &res);
>>  	pmecc->regs.errloc = (void *)res.start;
>>  
>> -	pmecc->regs.timing = 0;
>> -
>>  	/* pmecc data setup time */
>>  	if (caps->clk_ctrl)
>>  		writel(PMECC_CLK_133MHZ, pmecc->regs.base + ATMEL_PMECC_CLK);
>> @@ -952,7 +949,7 @@ static int atmel_pmecc_probe(struct udevice *dev)
>>  		return -EINVAL;
>>  	}
>>  
>> -	pmecc = atmel_pmecc_create(dev, caps, 0, 1, 2);
>> +	pmecc = atmel_pmecc_create(dev, caps, 0, 1);
>>  	if (IS_ERR(pmecc))
>>  		return PTR_ERR(pmecc);
>>  
>> diff --git a/drivers/mtd/nand/raw/atmel/pmecc.h b/drivers/mtd/nand/raw/atmel/pmecc.h
>> index 43f96b2f168c7b88e0c907996f2ae64f8554ed58..88b0d18040e7c48f226c74ce9b5caf93b5760360 100644
>> --- a/drivers/mtd/nand/raw/atmel/pmecc.h
>> +++ b/drivers/mtd/nand/raw/atmel/pmecc.h
>> @@ -65,7 +65,6 @@ struct atmel_pmecc {
>>  	struct {
>>  		void __iomem *base;
>>  		void __iomem *errloc;
>> -		void __iomem *timing;
>>  	} regs;
>>  
>>  	/* Mutex used for pmecc enable/disable */
> 
> Acked-by: Alexander Dahl <ada at thorsis.com>

Reviewed-by: Eugen Hristev <eugen.hristev at linaro.org>

> 
> Greets
> Alex
>