[PATCH 2/6] fat: Separate fat.c from fat_write.c

Heinrich Schuchardt heinrich.schuchardt at canonical.com
Fri Nov 14 12:49:47 CET 2025


On 11/14/25 11:55, Maarten Brock wrote:
> Hello Heinrich,
> 
> Don't you run the risk of getting into namespace problems when you make these
> static functions and global variables non-static? Esp. the ones without the word
> 'fat' in them seem to be in danger here.
> 
> E.g. downcase(), cur_dev, disk_read()
> 
> Kind Regards,
> Maarten

Thank you for reviewing. You are right. These functions should be 
renamed with a "fat_" prefix.

Best regards

Heinrich

> 
>> -----Original Message-----
>> From: U-Boot<u-boot-bounces at lists.denx.de> On Behalf Of Heinrich Schuchardt
>> Sent: Thursday, 13 November 2025 07:47
>> To: Tom Rini<trini at konsulko.com>
>> Cc: Simon Glass<simon.glass at canonical.com>; Gabriel Dalimonte
>> <gabriel.dalimonte at gmail.com>; AKASHI Takahiro<akashi.tkhro at gmail.com>; u-
>> boot at lists.denx.de; Claude<noreply at anthropic.com>; Heinrich Schuchardt
>> <heinrich.schuchardt at canonical.com>
>> Subject: [PATCH 2/6] fat: Separate fat.c from fat_write.c
>>
>> From: Simon Glass<simon.glass at canonical.com>
>>
>> Currently fat_write.c includes fat.c directly, which is unusual and
>> makes the code harder to maintain. Use the internal header file to hold
>> shared functions, to avoid this.
>>
>> Co-developed-by: Claude<noreply at anthropic.com>
>> Signed-off-by: Simon Glass<simon.glass at canonical.com>
>> Tested-by: Heinrich Schuchardt<heinrich.schuchardt at canonical.com>



More information about the U-Boot mailing list