[PATCH 2/6] fat: Separate fat.c from fat_write.c
Tom Rini
trini at konsulko.com
Fri Nov 14 15:15:56 CET 2025
On Fri, Nov 14, 2025 at 12:49:47PM +0100, Heinrich Schuchardt wrote:
> On 11/14/25 11:55, Maarten Brock wrote:
> > Hello Heinrich,
> >
> > Don't you run the risk of getting into namespace problems when you make these
> > static functions and global variables non-static? Esp. the ones without the word
> > 'fat' in them seem to be in danger here.
> >
> > E.g. downcase(), cur_dev, disk_read()
> >
> > Kind Regards,
> > Maarten
>
> Thank you for reviewing. You are right. These functions should be renamed
> with a "fat_" prefix.
I'm still working with my Claude-using friends, but I'd like to point
out that it too doesn't like the namespace pollution this series
contains (and so is part of a higher level problem I have).
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20251114/eab9b579/attachment.sig>
More information about the U-Boot
mailing list