[PATCH] boot: vbe: Make BOOTMETH_VBE_xxx a choice
Simon Glass
sjg at chromium.org
Mon Oct 6 14:26:20 CEST 2025
Hi Tom,
On Thu, 2 Oct 2025 at 11:03, Tom Rini <trini at konsulko.com> wrote:
>
> On Thu, Oct 02, 2025 at 10:29:58AM -0600, Simon Glass wrote:
> > Hi Tom,
> >
> > On Wed, 1 Oct 2025 at 14:33, Tom Rini <trini at konsulko.com> wrote:
> > >
> > > It is not valid to enable multiple BOOTMETH_VBE_xxx methods
> >
> > Why is it not valid? That wasn't my intention.
>
> They fail to build because they both declare some of the same binman
> syms:
> $ grep 'binman_sym_declare(ulong, vpl, size)' boot/vbe*.c
> boot/vbe_abrec_fw.c:binman_sym_declare(ulong, vpl, size);
> boot/vbe_simple_fw.c:binman_sym_declare(ulong, vpl, size);
> $ grep 'binman_sym_declare(ulong, vpl, image_pos)' boot/vbe*.c
> boot/vbe_abrec_fw.c:binman_sym_declare(ulong, vpl, image_pos);
> boot/vbe_simple_fw.c:binman_sym_declare(ulong, vpl, image_pos);
>
> Enabling both leads to link failures.
OK, thanks. I'll need to fix it at some point...
Regards,
Simon
More information about the U-Boot
mailing list