[PATCH] boot: vbe: Make BOOTMETH_VBE_xxx a choice

[Tom Rini]

On Mon, Oct 06, 2025 at 06:26:20AM -0600, Simon Glass wrote:
> Hi Tom,
> 
> On Thu, 2 Oct 2025 at 11:03, Tom Rini <trini at konsulko.com> wrote:
> >
> > On Thu, Oct 02, 2025 at 10:29:58AM -0600, Simon Glass wrote:
> > > Hi Tom,
> > >
> > > On Wed, 1 Oct 2025 at 14:33, Tom Rini <trini at konsulko.com> wrote:
> > > >
> > > > It is not valid to enable multiple BOOTMETH_VBE_xxx methods
> > >
> > > Why is it not valid? That wasn't my intention.
> >
> > They fail to build because they both declare some of the same binman
> > syms:
> > $ grep 'binman_sym_declare(ulong, vpl, size)' boot/vbe*.c
> > boot/vbe_abrec_fw.c:binman_sym_declare(ulong, vpl, size);
> > boot/vbe_simple_fw.c:binman_sym_declare(ulong, vpl, size);
> > $ grep 'binman_sym_declare(ulong, vpl, image_pos)' boot/vbe*.c
> > boot/vbe_abrec_fw.c:binman_sym_declare(ulong, vpl, image_pos);
> > boot/vbe_simple_fw.c:binman_sym_declare(ulong, vpl, image_pos);
> >
> > Enabling both leads to link failures.
> 
> OK, thanks. I'll need to fix it at some point...

At some point is fine, thanks.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20251006/7fbe5a48/attachment.sig>