[PATCH v4 09/10] riscv: boston: Add support for LED character display command

Yao Zi ziyao at disroot.org
Thu Oct 9 13:15:57 CEST 2025


On Tue, Aug 19, 2025 at 10:34:01AM +0000, Uros Stajic wrote:
> From: Chao-ying Fu <cfu at mips.com>
> 
> Add basic support for the 8-char LED display on P8700-based Boston
> Board using display_set() and display_putc(), enabling the generic
> 'display' command with clear and home support.

I noticed the similar "display" command has been removed back to 2019
in commit 005a804d0f3 (cmd: remove unused `display` command,
2019-05-21).

To me, It doesn't seem a good idea to add it back, at least more
discussion is necessary for it.

Could the driver be implemented as a stdio device instead? And could it
be described in devicetree to avoid non-DM code as much as possible?

Regards,
Yao Zi

> Signed-off-by: Chao-ying Fu <cfu at mips.com>
> Signed-off-by: Uros Stajic <uros.stajic at htecgroup.com>
> ---
>  board/mips/boston-riscv/Kconfig         |  4 ++
>  board/mips/boston-riscv/MAINTAINERS     |  3 ++
>  board/mips/boston-riscv/Makefile        |  1 +
>  board/mips/boston-riscv/display.c       | 33 ++++++++++++++++
>  board/mips/boston-riscv/lowlevel_init.S |  2 +
>  cmd/Kconfig                             |  8 ++++
>  cmd/Makefile                            |  1 +
>  cmd/display.c                           | 51 +++++++++++++++++++++++++
>  doc/README.LED_display                  | 26 +++++++++++++
>  include/led-display.h                   | 33 ++++++++++++++++
>  10 files changed, 162 insertions(+)
>  create mode 100644 board/mips/boston-riscv/display.c
>  create mode 100644 cmd/display.c
>  create mode 100644 doc/README.LED_display
>  create mode 100644 include/led-display.h


More information about the U-Boot mailing list