[PATCH] clk: exynos: Fix always true test

[Minkyu Kang]

Hi,


2025년 8월 8일 (금) 00:28, Andrew Goodbody <andrew.goodbody at linaro.org>님이 작성:

> On 23/07/2025 17:04, Andrew Goodbody wrote:
> > In exynos7420_peric1_get_rate the variable ret is declared as an
> > 'unsigned int' but is then used to receive the return value of
> > clk_get_by_index which returns an int. The value of ret is then tested
> > for being less than 0 which will always fail for an unsigned variable.
> > Fix this by declaring ret as an 'int' so that the test for the error
> > condition is valid.
> >
> > This issue was found by Smatch.
> >
> > Signed-off-by: Andrew Goodbody <andrew.goodbody at linaro.org>
> > ---
> >   drivers/clk/exynos/clk-exynos7420.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/clk/exynos/clk-exynos7420.c
> b/drivers/clk/exynos/clk-exynos7420.c
> > index 3aa751bf4e4..7de4e688f03 100644
> > --- a/drivers/clk/exynos/clk-exynos7420.c
> > +++ b/drivers/clk/exynos/clk-exynos7420.c
> > @@ -192,7 +192,7 @@ static int exynos7420_clk_top0_probe(struct udevice
> *dev)
> >   static ulong exynos7420_peric1_get_rate(struct clk *clk)
> >   {
> >       struct clk in_clk;
> > -     unsigned int ret;
> > +     int ret;
> >       unsigned long freq = 0;
> >
> >       switch (clk->id) {
> >
> > ---
> > base-commit: bd0ade7d090a334b3986936d63a34001d99722ad
> > change-id: 20250723-clk_exynos-b8ac6765f510
> >
> > Best regards,
>
> Are there any comments on this patch please?


applied to u-boot-samsung.

Thanks.
Minkyu Kang.


>
> Thanks,
> Andrew
>