[PATCH v3 2/3] configs: j721e_evm_r5: Enable HBMC and MUX_MMIO at SPL

[Tom Rini]

On Tue, Sep 02, 2025 at 09:36:25PM +0530, Kumar, Udit wrote:
> Hi Tom
> 
> On 9/2/2025 9:16 PM, Tom Rini wrote:
> > On Tue, Sep 02, 2025 at 03:49:59PM +0530, Anurag Dutta wrote:
> > 
> > > Commit 0e198ff1a911 ("configs: Resync with savedefconfig") removed
> > > the necessary configs required to boot HyperFlash successfully, due to
> > > missing Kconfig dependencies. Now that the Kconfig dependencies have
> > > been added, re-enable the HBMC and MUX_MMIO configs in the SPL stage.
> > > 
> > > Fixes: 0e198ff1a911 ("configs: Resync with savedefconfig")
> > > Signed-off-by: Anurag Dutta <a-dutta at ti.com>
> > Please note that this means it never worked to start with.
> > "savedefconfig" does the equivalent of "make foo_defconfig" and then
> 
> 
> It was working before but due to some boot issues , due to DT sync
> 
> we disabled HBMC with commit id 5b2671594b80af116e259313d48bcd580d71f462 .
> 
> 
> Instead of saying Fixes: 0e198ff1a91,
> 
> This patch is fixing sha id 5b2671594b80af116e259313d48bcd580d71f462 by kind
> of revert.
> 
> my bad to give R/B , overlooked on sha id of fixes tag.

Again, no, that's not quite how it works. When we do a defconfig resync
like this we're just making the defconfigs reflect the present reality.
If you checkout 5b2671594b80af116e259313d48bcd580d71f462^ and then look
at the resulting defconfig, that option will be off. Doing a git blame
on drivers/mtd/Kconfig the right fixes tag is for:
commit 8f71d37838ba0b0bfa047f5133877092ee9d1110
Author: Anurag Dutta <a-dutta at ti.com>
Date:   Fri Nov 29 17:01:36 2024 +0530

    mtd: Kconfig: Change HBMC driver's dependency to MULTIPLEXER and MUX_MMIO
    
    The HBMC_AM654 driver was dependent on SYSCON because syscon APIs were
    being used to select the multiplexer state. Change the dependency to
    MULTIPLEXER and MUX_MMIO because mux APIs are now being used to
    select mux state.
    
    Signed-off-by: Anurag Dutta <a-dutta at ti.com>

As that's what changed the dependencies for the option.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20250902/3ca0b383/attachment.sig>