[PATCH 1/2] timer: tegra: Bind watchdog driver when timer node is processed

[Svyatoslav Ryhel]

пн, 8 вер. 2025 р. о 15:41 Łukasz Majewski <lukma at nabladev.com> пише:
>
> Hi Svyatoslav,
>
> > вт, 26 серп. 2025 р. о 12:39 Lukasz Majewski <lukma at nabladev.com>
> > пише:
> > >
> > > The Tegra30 SoC is a bit special, as it doesn't have the separate
> > > IP block to provide watchdog functionality.
> > >
> > > Instead, timer IP block allows such functionality when properly
> > > configured.
> > >
> > > As in the tegra30.dtsi there is a timer node, which "covers" all
> > > timers, with 'nvidia,tegra30-timer' compatibility it was necessary
> > > to manually bind U-Boot's WDT driver (based on WDT_UCLASS).
> > >
> > > Signed-off-by: Lukasz Majewski <lukma at nabladev.com>
> > > ---
> > >  drivers/timer/tegra-timer.c | 18 ++++++++++++++++++
> > >  1 file changed, 18 insertions(+)
> > >
> >
> > What is the practical application for this diver in therms of Tegra
> > and U-Boot overall?
>
> You have the WDT functionality working. It uses the same DTS bindings
> as ones used in Linux.

Why do we need WDT for Tegra in U-Boot at all? It is not used and has
no practical application.

> > Where is can be used so that existing means of
> > U-Boot cannot handle such case?
>
> Currently u-boot for Tegra 30 doesn't support Watchdog at all...

Yes, and it does not affect or break anything.

> You have for example collibri T30 modules without WDT functionality
> support.

Correct and? ALL Tegra devices work perfectly fine WITHOUT WDT

> After adding those patches you can use WDT class (and wdt command) to
> control WDT.
>

And what is the benefit? To have a driver for the sake of having a driver?

> Do you have more specific questions?
>
>
> It is strange, but I've just noticed your reply (caused probably by my
> "work" mail switch), so I would like to apologize for a late reply.
>
>
> --
> Best regards,
>
> Lukasz Majewski
>
> --
> Nabla Software Engineering GmbH
> HRB 40522 Augsburg
> Phone: +49 821 45592596
> E-Mail: office at nabladev.com
> Geschftsfhrer : Stefano Babic