[PATCH] cmd/dma: fix generic naming, spacing, and Dependencies

[Tom Rini]

On Sat, Sep 13, 2025 at 04:04:14PM +0800, briansune wrote:

> This adds a new U-Boot command 'c5_pl330_dma' for Cyclone V SoCDK
> boards. It provides access to the Reset Manager's Per2ModRst register
> to release the reset for ARM PrimeCell PL330 DMA channels. This allows
> software to initialize and use the PL330 DMA controller properly after
> reset.
> 
> Tested-by: Sune Brian <briansune at gmail.com>
> Tested on: Cyclone V SoCDK
> 
> Signed-off-by: briansune <briansune at gmail.com>

This is better, yes. The subject should be fixed, your real name used in
the Signed-off-by (and you don't give yourself a Tested-by for what you
wrote). Also:

> ---
>  cmd/Kconfig        |  9 +++++++++
>  cmd/Makefile       |  1 +
>  cmd/c5_pl330_dma.c | 50 ++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 60 insertions(+)
>  create mode 100644 cmd/c5_pl330_dma.c
> 
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 29de857ba7c..75c388d19da 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -1791,6 +1791,15 @@ endmenu
>  
>  menu "Shell scripting commands"
>  
> +if TARGET_SOCFPGA_CYCLONE5_SOCDK
> +
> +config CMD_C5_PL330_DMA
> +	bool "Release Reset DMA Channels for PL330 Handshake"
> +	help
> +	  Provides access to Reset Manager Per2ModRst. Enables DMA
> +	  channels for ARM PrimeCell PL330 via reset release.
> +endif

This should just be "depends on TARGET_SOCFPGA_CYCLONE5_SOCDK" if it's
that specific and not slightly more usable on other SOCFPGA chipsets.

[snip]
> +static int do_dmareset(struct cmd_tbl *cmdtp, int flag, int argc,
> +	char * const argv[])

This spacing is still wrong and what checkpatch.pl notes. Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20250913/e4fe8070/attachment.sig>