[PATCH v1 4/8] spl: ubi: refactor spl_ubi_load_image for falcon mode
Anshul Dalal
anshuld at ti.com
Wed Sep 17 15:33:57 CEST 2025
On Wed Sep 17, 2025 at 12:04 AM IST, Tom Rini wrote:
> On Tue, Sep 16, 2025 at 04:28:52PM +0530, Anshul Dalal wrote:
>
>> This patch moves the falcon mode handling logic out of
>> spl_ubi_load_image to spl_ubi_load_image_os, this allows for cleaner
>> handling for fallback to U-Boot in case falcon mode fails.
>>
>> Signed-off-by: Anshul Dalal <anshuld at ti.com>
> [snip]
>> - puts("Loading Linux failed, falling back to U-Boot.\n");
>> + printf("%s: Failed in falcon boot: %d", __func__, ret);
>> + printf("Fallback to U-Boot\n");
>
> Switching from puts to printf doesn't gain us new information here and
> may pull in printf when we only had puts before. SPL needs more
> consideration than usual about size growth.
You're right, I'll revert back to puts in the next revision. The
existing log should suffice.
Regards,
Anshul
More information about the U-Boot
mailing list