[PATCH 1/1] board: ti: am335x: Do not call disabled PMIC functions

[Maarten Brock]

> From: Tom Rini <trini at konsulko.com>
> On Mon, Sep 08, 2025 at 04:05:04PM +0000, Maarten Brock wrote:
> 
> > When PMIC drivers are disabled their functions should not be called.
> >
> > Signed-off-by: Maarten Brock <maarten.brock at sttls.nl>
> > ---
> >
> >  board/ti/am335x/board.c | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/board/ti/am335x/board.c b/board/ti/am335x/board.c
> > index 2b7ab68e83c..284c31cc329 100644
> > --- a/board/ti/am335x/board.c
> > +++ b/board/ti/am335x/board.c
> > @@ -283,7 +283,7 @@ const struct dpll_params *get_dpll_ddr_params(void)
> >
> >  static u8 bone_not_connected_to_ac_power(void)
> >  {
> > -	if (board_is_bone()) {
> > +	if (CONFIG_IS_ENABLED(PMIC_TPS65217) && board_is_bone()) {
> >  		uchar pmic_status_reg;
> >  		if (tps65217_reg_read(TPS65217_STATUS,
> >  				      &pmic_status_reg))
> 
> The problem is that here and elsewhere we don't have SPL_xxx symbols and
> so we're turning off these calls in SPL now on the platforms which would
> be calling them.

That would be really odd. The function tps65217_reg_read() is not defined when CONFIG_PMIC_TPS65217 is not defined. So how could these calls work then? For me it leads to a build failure. Or did I use an incorrect macro with CONFIG_IS_ENABLED to solve this?

Kind Regards,
Maarten Brock