回复: [EXT] Re: [PATCH v1 4/8] imx9: scmi: Update the files under arch/arm/mach-imx/imx9/scmi/ to support i.MX94

[Alice Guo (OSS)]

> -----邮件原件-----
> 发件人: Tom Rini <trini at konsulko.com>
> 发送时间: 2025年9月22日 0:07
> 收件人: Fabio Estevam <festevam at gmail.com>
> 抄送: Alice Guo (OSS) <alice.guo at oss.nxp.com>; E Shattow <e at freeshell.de>;
> Stefano Babic <sbabic at nabladev.com>; dl-uboot-imx <uboot-imx at nxp.com>;
> Alice Guo <alice.guo at nxp.com>; u-boot at lists.denx.de; Ye Li <ye.li at nxp.com>;
> Peng Fan <peng.fan at nxp.com>; Jacky Bai <ping.bai at nxp.com>
> 主题: Re: [EXT] Re: [PATCH v1 4/8] imx9: scmi: Update the files under
> arch/arm/mach-imx/imx9/scmi/ to support i.MX94
> 
> On Sun, Sep 21, 2025 at 09:15:43AM -0300, Fabio Estevam wrote:
> > Hi Alice,
> >
> > On Thu, Sep 11, 2025 at 3:42 AM Alice Guo (OSS) <alice.guo at oss.nxp.com>
> wrote:
> >
> > > > >  #include
> "../../../../../dts/upstream/src/arm64/freescale/imx95-clock.h"
> > > >
> > > > What is this? I asked and it was suggested to send a patch
> > > > upstream, but they said no. Ref:
> > ...
> > > This line of code is unnecessary and can be deleted.
> >
> > > > Again this weird include relative-global path... not good.
> > > >
> > > > I don't know what it should be, sorry. It is fragile and we should
> > > > do something better.
> > > >
> > >
> > > These files are derived from the Linux source code.
> >
> > Please address E Shattow's comments and send a v2 that also contains
> > the imx94-evk support.
> >
> > This way, we can achieve build coverage for the entire series.
> 
> There was some discussion of this on IRC as well, and the issue is that (for now?)
> this header in the kernel is supposed to be with the dts files and not dt-bindings
> and so it's not in a normal search path.
> 
> I think that for us that means we should do some Makefile games in that
> directory and add a -I$(srctree)/dts/... and comment in the code to say this is a
> DT header file.
> 
> --
> Tom

Hi Tom,

Thank you for your suggestion. I will address this issue by modifying the Makefile in the next version.

Best regards,
Alice Guo