[PATCH] cmd/dma: fix generic naming, spacing, and Dependencies
Quentin Schulz
quentin.schulz at cherry.de
Tue Sep 23 13:47:31 CEST 2025
Hi Brian,
The git commit title doesn't seem related to the actual content of the
patch?
On 9/13/25 6:39 PM, briansune wrote:
> [You don't often get email from briansune at gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> This adds a new U-Boot command 'c5_pl330_dma' for Cyclone V SoCDK
> boards. It provides access to the Reset Manager's Per2ModRst register
> to release the reset for ARM PrimeCell PL330 DMA channels. This allows
> software to initialize and use the PL330 DMA controller properly after
> reset.
Isn't this something that should be done by boards directly (i.e.
somewhere in board/ directory) or at the SoC/arch level (i.e. arch/arm
or arch/arm/mach-socfpga) or handle that in a DMA driver (I assume
there's none now looking at drivers/dma/)? Essentially the question is
"why do we need this as a command?".
>
> Signed-off-by: briansune <briansune at gmail.com>
Needs to be Brian Sune here (same for the commit author which you can
change with git commit --amend --author="Brian Sune
<briansune at gmail.com>" if I remember correctly).
> ---
> cmd/4913 | 0
> cmd/5036 | 0
We don't need those files I assume?
Cheers,
Quentin
More information about the U-Boot
mailing list