[PATCH v1] arm: socfpga: mailbox: Remove CONFIG_CADENCE_QSPI guard from QSPI mailbox API declarations

Chee, Tien Fong tien.fong.chee at altera.com
Thu Sep 25 05:07:41 CEST 2025



> -----Original Message-----
> From: Yuslaimi, Alif Zakuan <alif.zakuan.yuslaimi at altera.com>
> Sent: Tuesday, 23 September, 2025 9:32 AM
> To: u-boot at lists.denx.de
> Cc: Marek Vasut <marek.vasut+renesas at mailbox.org>; Simon Goldschmidt
> <simon.k.r.goldschmidt at gmail.com>; Chee, Tien Fong
> <tien.fong.chee at altera.com>; Tom Rini <trini at konsulko.com>; Ng, Boon Khai
> <boon.khai.ng at altera.com>; Yuslaimi, Alif Zakuan
> <alif.zakuan.yuslaimi at altera.com>
> Subject: [PATCH v1] arm: socfpga: mailbox: Remove CONFIG_CADENCE_QSPI
> guard from QSPI mailbox API declarations
> 
> From: Alif Zakuan Yuslaimi <alif.zakuan.yuslaimi at altera.com>
> 
> The QSPI mailbox API function declarations (mbox_qspi_close and
> mbox_qspi_open) in mailbox_s10.h were guarded by CONFIG_CADENCE_QSPI
> preprocessor conditional. This prevented their prototypes from being visible to
> code that may use the stub implementations when CONFIG_CADENCE_QSPI is
> disabled.
> 
> Remove the CONFIG_CADENCE_QSPI preprocessor conditional so these
> functions are always declared, regardless of the configuration. This avoids
> potential build or linkage errors when stubs are used.
> 
> Signed-off-by: Alif Zakuan Yuslaimi <alif.zakuan.yuslaimi at altera.com>
> ---
>  arch/arm/mach-socfpga/include/mach/mailbox_s10.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm/mach-socfpga/include/mach/mailbox_s10.h
> b/arch/arm/mach-socfpga/include/mach/mailbox_s10.h
> index 2099c51b682..1a461de4819 100644
> --- a/arch/arm/mach-socfpga/include/mach/mailbox_s10.h
> +++ b/arch/arm/mach-socfpga/include/mach/mailbox_s10.h
> @@ -398,10 +398,8 @@ int mbox_rcv_resp(u32 *resp_buf, u32
> resp_buf_max_len);  int mbox_rcv_resp_psci(u32 *resp_buf, u32
> resp_buf_max_len);  int mbox_init(void);
> 
> -#ifdef CONFIG_CADENCE_QSPI
>  int mbox_qspi_close(void);
>  int mbox_qspi_open(void);
> -#endif
> 
>  int mbox_reset_cold(void);
>  int mbox_hps_stage_notify(u32 execution_stage);
> --
> 2.35.3

Reviewed-by: Tien Fong Chee <tien.fong.chee at altera.com>

Best regards,
Tien Fong



More information about the U-Boot mailing list