[PATCH 1/2] test: led: Add missing ';'

Christian Marangi ansuelsmth at gmail.com
Mon Sep 29 12:14:09 CEST 2025


On Thu, Sep 25, 2025 at 02:50:25PM -0600, Tom Rini wrote:
> Some tests here had not been compile tested before submission and were
> missing a ';' on the end of declaring struct udevice *dev. Add it.
> 
> Fixes: 9046279d92bb ("test: dm: Add tests for LED boot and activity")
> Signed-off-by: Tom Rini <trini at konsulko.com>
> ---
> Cc: Christian Marangi <ansuelsmth at gmail.com>
> ---

Sorry Tom for not catching this, I hoped the CI enabled these config.

Does the CI for these test use the SANDBOX defconfig?

Just to prevent similar error in the future.

>  test/dm/led.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/test/dm/led.c b/test/dm/led.c
> index 36652c2833a9..f41a2fb73fc0 100644
> --- a/test/dm/led.c
> +++ b/test/dm/led.c
> @@ -162,7 +162,7 @@ DM_TEST(dm_test_led_blink, UTF_SCAN_PDATA | UTF_SCAN_FDT);
>  #ifdef CONFIG_LED_BOOT
>  static int dm_test_led_boot(struct unit_test_state *uts)
>  {
> -	struct udevice *dev
> +	struct udevice *dev;
>  
>  	/* options/u-boot/boot-led is set to phandle to "sandbox:green" */
>  	ut_assertok(led_get_by_label("sandbox:green", &dev));
> @@ -180,7 +180,7 @@ DM_TEST(dm_test_led_boot, UTF_SCAN_PDATA | UTF_SCAN_FDT);
>  #ifndef CONFIG_LED_BLINK
>  static int dm_test_led_boot_blink(struct unit_test_state *uts)
>  {
> -	struct udevice *dev
> +	struct udevice *dev;
>  
>  	/* options/u-boot/boot-led is set to phandle to "sandbox:green" */
>  	ut_assertok(led_get_by_label("sandbox:green", &dev));
> @@ -200,7 +200,7 @@ DM_TEST(dm_test_led_boot_blink, UTF_SCAN_PDATA | UTF_SCAN_FDT);
>  #ifdef CONFIG_LED_ACTIVITY
>  static int dm_test_led_activity(struct unit_test_state *uts)
>  {
> -	struct udevice *dev
> +	struct udevice *dev;
>  
>  	/* options/u-boot/activity-led is set to phandle to "sandbox:red" */
>  	ut_assertok(led_get_by_label("sandbox:red", &dev));
> @@ -218,7 +218,7 @@ DM_TEST(dm_test_led_activity, UTF_SCAN_PDATA | UTF_SCAN_FDT);
>  #ifndef CONFIG_LED_BLINK
>  static int dm_test_led_activityt_blink(struct unit_test_state *uts)
>  {
> -	struct udevice *dev
> +	struct udevice *dev;
>  
>  	/* options/u-boot/activity-led is set to phandle to "sandbox:red" */
>  	ut_assertok(led_get_by_label("sandbox:red", &dev));
> -- 
> 2.43.0
> 

-- 
	Ansuel


More information about the U-Boot mailing list