[PATCH] include: completion.h: Convert the rest of the dummy functions to macros

Tom Rini trini at konsulko.com
Mon Sep 29 15:58:48 CEST 2025


On Mon, Sep 29, 2025 at 10:45:24AM +0800, Peng Fan wrote:
> Hi Tom,
> 
> On Fri, Sep 26, 2025 at 09:31:28AM -0600, Tom Rini wrote:
> >While we declare some of our dummy functions as "inline" we do not also
> >declare them as "static" and so it is possible for the compiler to
> >decide to make these as global functions instead. This can lead to link
> >time failures in some cases, such as "allyesconfig". As these are just
> >dummy functions, convert them to a macro instead.
> >
> 
> Sorry for my ignorance, why we not follow Linux Kernel to use "static inline"?

I don't have a strong preference. Doing these as simple macros matches
the rest of our dummy functions here.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20250929/a77e086b/attachment.sig>


More information about the U-Boot mailing list