[PATCH] usb: dwc3: Remove redundant test
Konstantin Ryabitsev
konstantin at linuxfoundation.org
Mon Sep 29 16:32:38 CEST 2025
On Mon, Sep 29, 2025 at 08:15:07AM -0600, Tom Rini wrote:
> > So it looks like the default command used by b4 for the Cc: section is
> > "scripts/get_maintainer.pl --nogit --nogit-fallback --nogit-chief-penguins
> > --norolestats --nom" which causes recent signers to not be included due to
> > the '--nogit' argument.
> >
> > I have added the following to my git config file.
> >
> > [b4]
> > send-auto-cc-cmd = scripts/get_maintainer.pl --nogit-fallback
> > --nogit-chief-penguins --norolestats --nom
> >
> > This will mean that from now on recent signers will be added to the Cc:
> > list. I hope that this is what is expected.
> >
> > I will resend this patch with the expanded Cc: list.
>
> A while back someone submitted a .b4.conf (or .b4.config? I forget...)
.b4-config
> patch, but at the time it wasn't setting anything non-standard I
> thought. However, is the above something that can be configured there?
> If so, that would be good to put in a project-wide b4 config file, and
> if it's not it'd be a good feature request for upstream.
Yeah, we try to walk a fine balance between being newbie-friendly but also
allowing power users to tweak things. The decision to add --nogit by default
was because for most subsystems this returns a list of CC's that is way too
huge and actually trips up some MTAs to refuse delivery with "too many
recipients."
The biggest downside of providing settings in the toplevel .b4-config is that
it can't currently be done per-subsystem, so projects like the kernel cannot
carry a .b4-config without it clashing between what different subsystems want
to set as defaults. I've not yet come up with a good way to solve this.
-K
More information about the U-Boot
mailing list