[PATCH 1/5] pinctrl: qcom: sc7280: Fix offset of UFS_RESET

Neil Armstrong neil.armstrong at linaro.org
Tue Sep 30 20:38:15 CEST 2025


On 9/24/25 13:30, Luca Weiss wrote:
> There's no WEST, SOUTH or NORTH in sc7280 pinctrl. Fix the offset of the
> ufs_reset pin.
> 
> Fixes: 51ec7fdb64b ("pinctrl: qcom: add sc7280 pinctrl driver")
> Signed-off-by: Luca Weiss <luca.weiss at fairphone.com>
> ---
>   drivers/pinctrl/qcom/pinctrl-sc7280.c | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280.c b/drivers/pinctrl/qcom/pinctrl-sc7280.c
> index fe87947fbbf9c27509498c1da982997e4d542478..d62b2cc6fb6b3e50773df7cd8bdedd43841c540a 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sc7280.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sc7280.c
> @@ -10,10 +10,6 @@
>   
>   #include "pinctrl-qcom.h"
>   
> -#define WEST 0x00000000
> -#define SOUTH 0x00400000
> -#define NORTH 0x00800000
> -
>   #define MAX_PIN_NAME_LEN 32
>   static char pin_name[MAX_PIN_NAME_LEN] __section(".data");
>   
> @@ -47,7 +43,7 @@ static const struct pinctrl_function msm_pinctrl_functions[] = {
>   	}
>   
>   static const struct msm_special_pin_data sc7280_special_pins_data[] = {
> -	[0] = UFS_RESET("ufs_reset", SOUTH + 0xbe000),
> +	[0] = UFS_RESET("ufs_reset", 0xbe000),
>   	[1] = SDC_PINGROUP("sdc1_rclk", 0xb3004, 0, 6),
>   	[2] = SDC_PINGROUP("sdc1_clk", 0xb3000, 13, 6),
>   	[3] = SDC_PINGROUP("sdc1_cmd", 0xb3000, 11, 3),
> 

Reviewed-by: Neil Armstrong <neil.armstrong at linaro.org>


More information about the U-Boot mailing list