[PATCH 1/2] test: led: Add missing ';'

Christian Marangi ansuelsmth at gmail.com
Tue Sep 30 22:22:20 CEST 2025


On Mon, Sep 29, 2025 at 08:03:41AM -0600, Tom Rini wrote:
> On Mon, Sep 29, 2025 at 12:14:09PM +0200, Christian Marangi wrote:
> > On Thu, Sep 25, 2025 at 02:50:25PM -0600, Tom Rini wrote:
> > > Some tests here had not been compile tested before submission and were
> > > missing a ';' on the end of declaring struct udevice *dev. Add it.
> > > 
> > > Fixes: 9046279d92bb ("test: dm: Add tests for LED boot and activity")
> > > Signed-off-by: Tom Rini <trini at konsulko.com>
> > > ---
> > > Cc: Christian Marangi <ansuelsmth at gmail.com>
> > > ---
> > 
> > Sorry Tom for not catching this, I hoped the CI enabled these config.
> > 
> > Does the CI for these test use the SANDBOX defconfig?
> > 
> > Just to prevent similar error in the future.
> 
> The issue is that the new options weren't enabled on sandbox as well.
> 

Yes sorry if I wasn't clear. I was honestly confused on where the config
were taken for CI and I assumed they were all enabled by default.

Thanks for confirming that the config for CI needs to be enabled in the
sandbox defconfig.

And again sorry for this embarassing error!

-- 
	Ansuel


More information about the U-Boot mailing list