[v3,01/15] mbedtls: enable support of ecc

Simon Glass sjg at chromium.org
Thu Apr 2 15:37:04 CEST 2026


Hi Philippe,

On 2026-03-31T10:00:34, Philippe Reynes <philippe.reynes at softathome.com> wrote:
> diff --git a/lib/mbedtls/mbedtls_def_config.h b/lib/mbedtls/mbedtls_def_config.h
> @@ -89,6 +89,24 @@
> +#define MBEDTLS_ECP_DP_SECP256K1_ENABLED
> +#define MBEDTLS_ECP_DP_SECP192R1_ENABLED
> +#define MBEDTLS_ECP_DP_SECP224R1_ENABLED
> +#define MBEDTLS_ECP_DP_SECP256R1_ENABLED
> +#define MBEDTLS_ECP_DP_SECP384R1_ENABLED
> +#define MBEDTLS_ECP_DP_SECP521R1_ENABLED
> +#define MBEDTLS_ECP_DP_SECP192K1_ENABLED
> +#define MBEDTLS_ECP_DP_SECP224K1_ENABLED
> +#define MBEDTLS_ECP_DP_SECP256K1_ENABLED
> +#define MBEDTLS_ECP_DP_BP256R1_ENABLED
> +#define MBEDTLS_ECP_DP_BP384R1_ENABLED
> +#define MBEDTLS_ECP_DP_BP512R1_ENABLED

MBEDTLS_ECP_DP_SECP256K1_ENABLED is defined twice in this block -
please remove the duplicate.

> diff --git a/configs/amd_versal2_virt_defconfig b/configs/amd_versal2_virt_defconfig
> @@ -164,6 +164,7 @@ CONFIG_VIRTIO_MMIO=y
> +CONFIG_ECDSA=y

The commit message says "Enables the support of ecc in mbedtls" but
this is doing more than that - it also adds CONFIG_ECDSA to several
defconfigs which is a functional change. Please can you explain in the
commit message why these boards need ECDSA enabled? Probably should be
a separate commit, too.

Regards,
Simon


More information about the U-Boot mailing list