[v3,04/15] drivers: crypto: add software ecdsa support

[Simon Glass]

Hi Philippe,

On 2026-03-31T10:00:34, Philippe Reynes <philippe.reynes at softathome.com> wrote:
> diff --git a/drivers/crypto/ecdsa/Kconfig b/drivers/crypto/ecdsa/Kconfig
> +config ECDSA_SW
> +     bool "Enable driver for ECDSA in software"
> +     depends on ECDSA_MBEDTLS
> +     depends on ECDSA_VERIFY

Raymond has already pointed out on the cover letter that ECDSA_SW may
be unnecessary given this is a MbedTLS-only solution. If a future
non-MbedTLS software implementation is anticipated, this separation
makes sense, but please consider his suggestion to simplify and use
ECDSA_MBEDTLS directly.

> diff --git a/drivers/crypto/ecdsa/Kconfig b/drivers/crypto/ecdsa/Kconfig
> +     help
> +       Enable driver for ECDSA operations in software. Currently
> +       it supports multiple ECDSA algorithm.

\ No newline at end of file

Please add a trailing newline to the Kconfig file. Also "multiple
ECDSA algorithm" should be "multiple ECDSA algorithms" (plural).

> diff --git a/drivers/crypto/ecdsa/ecdsa-sw.c b/drivers/crypto/ecdsa/ecdsa-sw.c
> +U_BOOT_DRVINFO(sw_ecdsa) = {
> +     .name = "sw_ecdsa",
> +};

This file also needs a trailing newline.

> diff --git a/drivers/crypto/ecdsa/ecdsa-sw.c b/drivers/crypto/ecdsa/ecdsa-sw.c
> +#include <dm/device.h>
> +#include <linux/types.h>
> +#include <u-boot/ecdsa.h>
> +#include <crypto/ecdsa-uclass.h>
> +#include <dm/platdata.h>
> +#include <crypto/internal/ecdsa.h>

Please sort the includes alphabetically as per U-Boot convention. Also
<dm.h> is the standard include for driver model, rather than the
individual <dm/device.h> and <dm/platdata.h> headers.

>     drivers: crypto: add software ecdsa support
>
>     Add an software ecdsa driver so it is

Add a software

Regards,
Simon