[PATCH] drivers: clk: altera: arria10: Fix wrong API used for memory free
Chee, Tien Fong
tien.fong.chee at altera.com
Mon Apr 13 12:13:38 CEST 2026
Hi Dinesh,
> From: Maniyam, Dinesh <dinesh.maniyam at altera.com>
> Sent: Wednesday, February 25, 2026 1:01 PM
> To: u-boot at lists.denx.de <u-boot at lists.denx.de>
> Cc: Marek Vasut <marex at denx.de>; Simon Goldschmidt
> <simon.k.r.goldschmidt at gmail.com>; Tom Rini <trini at konsulko.com>; Lukasz
> Majewski <lukma at denx.de>; Chee, Tien Fong <tien.fong.chee at altera.com>; Hea,
> Kok Kiang <kok.kiang.hea at altera.com>; Maniyam, Dinesh
> <dinesh.maniyam at altera.com>; Ng, Boon Khai <boon.khai.ng at altera.com>;
> Yuslaimi, Alif Zakuan <alif.zakuan.yuslaimi at altera.com>
> Subject: [PATCH] drivers: clk: altera: arria10: Fix wrong API used for memory
> free
> From: Dinesh Maniyam <dinesh.maniyam at altera.com>
> Fix the wrong API used for memory free.
> Signed-off-by: Dinesh Maniyam <dinesh.maniyam at altera.com>
> ---
> drivers/clk/altera/clk-arria10.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/drivers/clk/altera/clk-arria10.c
> b/drivers/clk/altera/clk-arria10.c
> index 1840f73beee..e56e94adae0 100644
> --- a/drivers/clk/altera/clk-arria10.c
> +++ b/drivers/clk/altera/clk-arria10.c
> @@ -223,7 +223,7 @@ static void socfpga_a10_handoff_workaround(struct udevice
> *dev)
> ret = clk_request(dev, &bulk->clks[0]);
> if (ret)
> - free(bulk->clks);
> + devm_kfree(dev, bulk->clks);
you must still reset bulk->clks = NULL and bulk->count = 0 so nothing reads the old shape, treating pointer/count reset as part of “secure cleanup”
bulk->clks = NULL;
bulk->count = 0;
> }
> static int socfpga_a10_clk_bind(struct udevice *dev)
> --
> 2.43.7
Best regards,
Tien Fong
More information about the U-Boot
mailing list