[PATCH 2/4] net: cpsw: Remove compat string argument

Markus Schneider-Pargmann msp at baylibre.com
Tue Apr 14 09:01:20 CEST 2026


Hi Maarten,

On Mon Apr 13, 2026 at 11:00 AM CEST, Maarten Brock wrote:
> Hi Markus,
>
>> diff --git a/drivers/net/ti/cpsw.c b/drivers/net/ti/cpsw.c index 6bfdbb60091ac1cb7ef5a0bb3ad5221c2c11206f..c844416d50ca3db9bb0d9ffe56cd9c352b8c58b0 100644
>> --- a/drivers/net/ti/cpsw.c
>> +++ b/drivers/net/ti/cpsw.c
>> @@ -1064,9 +1064,10 @@ static void cpsw_gmii_sel_dra7xx(struct cpsw_priv *priv,
>>  	writel(reg, priv->data->gmii_sel);
>>  }
>>  
>> -static void cpsw_phy_sel(struct cpsw_priv *priv, const char *compat,
>> -			 phy_interface_t phy_mode)
>> +static void cpsw_phy_sel(struct cpsw_priv *priv, phy_interface_t 
>> +phy_mode)
>
> Indent please. And consider to keep the type on the same line as the parameter.

I think this may have been your mail client? At least in my git patch
and the patch I can see I sent it is all on one line:

+static void cpsw_phy_sel(struct cpsw_priv *priv, phy_interface_t phy_mode)

Best
Markus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 289 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20260414/a7a18a0a/attachment.sig>


More information about the U-Boot mailing list