[PATCH 2/4] net: cpsw: Remove compat string argument

[Maarten Brock]

Hi Markus,

To my shameful surprise, you are right.
My company forces me to use broken software and this was one of its "features".
I have now turned it off, who knows how long it will hold.

Other features include: resetting the cursor to the top-left while you are writing an email.

Kind regards,
Maarten

> -----Original Message-----
> From: Markus Schneider-Pargmann <msp at baylibre.com>
> Sent: Tuesday 14 April 2026 9:01
> To: Maarten Brock <Maarten.Brock at sttls.nl>; Markus Schneider-Pargmann (TI) <msp at baylibre.com>; u-boot at lists.denx.de
> Cc: Jerome Forissier <jerome.forissier at arm.com>; Tom Rini <trini at konsulko.com>
> Subject: Re: [PATCH 2/4] net: cpsw: Remove compat string argument
> 
> Hi Maarten,
> 
> On Mon Apr 13, 2026 at 11:00 AM CEST, Maarten Brock wrote:
> > Hi Markus,
> >
> >> diff --git a/drivers/net/ti/cpsw.c b/drivers/net/ti/cpsw.c index
> 6bfdbb60091ac1cb7ef5a0bb3ad5221c2c11206f..c844416d50ca3db9bb0d9ffe56cd9c352b8c58b0 100644
> >> --- a/drivers/net/ti/cpsw.c
> >> +++ b/drivers/net/ti/cpsw.c
> >> @@ -1064,9 +1064,10 @@ static void cpsw_gmii_sel_dra7xx(struct cpsw_priv *priv,
> >>  	writel(reg, priv->data->gmii_sel);
> >>  }
> >>
> >> -static void cpsw_phy_sel(struct cpsw_priv *priv, const char *compat,
> >> -			 phy_interface_t phy_mode)
> >> +static void cpsw_phy_sel(struct cpsw_priv *priv, phy_interface_t
> >> +phy_mode)
> >
> > Indent please. And consider to keep the type on the same line as the parameter.
> 
> I think this may have been your mail client? At least in my git patch
> and the patch I can see I sent it is all on one line:
> 
> +static void cpsw_phy_sel(struct cpsw_priv *priv, phy_interface_t phy_mode)
> 
> Best
> Markus