[PATCH v3 07/11] mach-snapdragon: Kconfig: changes / additions to support SPL

[Simon Glass]

Hi Michael,

On 2026-04-21T19:43:46, Michael Srba <michael.srba at seznam.cz> wrote:
> mach-snapdragon: Kconfig: changes / additions to support SPL
>
> An SoC to target has to be selected, e.g. SPL_TARGET_SDM845.
> This will select reasonable defaults and enable per-SoC linker
> script (if required).
>
> Signed-off-by: Michael Srba <Michael.Srba at seznam.cz>
>
> arch/arm/Kconfig                 | 33 ++++++++++++++++++++++++++++++++-
>  arch/arm/mach-snapdragon/Kconfig | 31 ++++++++++++++++++++++++++++---
>  2 files changed, 60 insertions(+), 4 deletions(-)

> diff --git a/arch/arm/mach-snapdragon/Kconfig b/arch/arm/mach-snapdragon/Kconfig
> @@ -42,4 +39,32 @@ config SYS_CONFIG_NAME
> +config TARGET_SDM845
> +     bool "SPL targeting the sdm845 SoC"
> +     help
> +       Select this if you are bulding u-boot SPL for sdm845.

Typo: 'bulding' should be 'building'.

> diff --git a/arch/arm/mach-snapdragon/Kconfig b/arch/arm/mach-snapdragon/Kconfig
> @@ -42,4 +39,32 @@ config SYS_CONFIG_NAME
> +choice
> +     prompt "Qualcomm SoC select"
> +     default TARGET_NONE if !SPL
> +     help
> +       While U-Boot on Qualcomm platforms doesn't generally need compile-time
> +       adjustment based on the target SoC, there are a few exceptions to this.
> +       Currently this concerns boot0.h discrimination.
> +
> +config TARGET_NONE
> +     bool "Generic build"

The commit message says 'e.g. SPL_TARGET_SDM845' but the actual config
symbol is TARGET_SDM845. Please fix the commit message.

> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> @@ -1124,6 +1124,7 @@ config ARCH_SNAPDRAGON
> +     select SPL_SPMI_MSM if SPL

SPL_SPMI_MSM depends on SPL_SPMI (from patch 3), but SPL_SPMI is not
selected here. It might be cleaner to also explicitly select SPL_SPMI
if SPL

Regards,
Simon