[PATCH v5 04/15] mach-sc5xx: Switch from tftp to wget

[Simon Glass]

Hi Caleb,

On 2026-04-23T14:24:50, Caleb Ethridge <jcethrid at gmail.com> wrote:
> mach-sc5xx: Switch from tftp to wget
>
> Switch the nfsboot and other relevant commands to use
> wget instead of tftp. This also includes the addition of
> the httpdstp variable for selecting the wget port.
>
> The default port is set to 8000 instead of the usual 80
> to allow for use with an unprivileged web server.
>
> Signed-off-by: Caleb Ethridge <caleb.ethridge at analog.com>
>
> include/env/adi/adi_boot.env | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)

> diff --git a/include/env/adi/adi_boot.env b/include/env/adi/adi_boot.env
> @@ -27,15 +28,14 @@ adi_bootargs=EARLY_PRINTK console=ttySC0,CONFIG_BAUDRATE vmalloc=512M
>  /* Boot modes are selectable and should be defined in the board env before including */
>  #if defined(USE_NFS)
> -// rootpath is set by CONFIG_ROOTPATH
>  nfsargs=setenv bootargs root=/dev/nfs rw nfsroot=${serverip}:${rootpath},tcp,nfsvers=3 ${adi_bootargs}
> -nfsboot=run init_ethernet;
> -     tftp ${loadaddr} ${tftp_dir_prefix}${imagefile};
> -     run nfsargs;
> +nfsboot= run nfsargs;
>       run addip;
> +     wget ${loadaddr} ${serverip}:/fitImage;
>       bootm ${loadaddr}

A few thoughts:

1. Dropping init_ethernet is a behavioural change: there is no longer
a dhcp or setenv serverip ${tftpserverip} before the wget. wget will
not auto-DHCP, so a user with no static IP will see this fail. Either
keep a network-bring-up step or call this out explicitly in the commit
message.

2. 'nfsboot= run nfsargs;' has a stray leading space after '=' (same
in 'ramboot= wget ...' below). Please drop it.

3. The image path is now hard-coded to /fitImage instead of
${tftp_dir_prefix}${imagefile}. The commit message suggetss this is a
pure tftp->wget switch, but it also removes the user-configurable
filename/prefix. If that is intentional, please say so; otherwise keep
${imagefile} and let boards override it.

Regards,
Simon