[PATCH] drivers: clk: n5x: Fix incorrect EMAC clock source selection

LOK, CHEN HUEI chen.huei.lok at altera.com
Tue Jun 23 03:44:06 CEST 2026


Hi Tien Fong,

On 22/6/2026 7:09 pm, Tien Fong Chee wrote:
> The fix is correct either way. Agilex uses FIELD_GET(); Agilex5 uses the
> same mask-then-shift this patch applies. FIELD_GET would be a minor
> consistency nit only.
>
> ctl = FIELD_GET(CLKMGR_PERPLLGRP_EMACCTL_EMAC0SELB_MASK, ctl);
>
> Add FIELD_GET in second commit and keep the current as first commit.

Sounds good. I'll keep this mask-then-shift fix as patch 1/2 (unchanged,
the functional fix) and add a second patch 2/2 that converts the field
extraction to FIELD_GET() (plus #include <linux/bitfield.h>), matching
the Agilex clock driver.

I'll send it as a v2 series. Tested on N5X SoCDK hardware.

Best regards,
Lok


More information about the U-Boot mailing list