[PATCH v2 0/2] drivers: clk: n5x: Fix and clean up EMAC clock source selection
Chen Huei Lok
chen.huei.lok at altera.com
Tue Jun 23 04:07:50 CEST 2026
This series fixes the EMAC clock source selection in the N5X clock
driver and then cleans it up to match the Agilex clock driver.
Patch 1 is the functional fix that was sent as v1: the mask was applied
after the shift instead of before, so EMAC always read the clock source
as emaca_free_clk. Patch 2 is a follow-up readability change that
replaces the open-coded mask-and-shift with FIELD_GET(), as suggested by
Tien Fong on the v1 review, aligning N5X with the existing Agilex usage.
Tested on Intel SoCFPGA N5X SoCDK hardware.
v1->v2:
--------
- No functional change to the fix (patch 1).
- New patch 2: use FIELD_GET() for the EMAC clock source select field,
for consistency with the Agilex clock driver (Tien Fong's review nit).
History:
--------
[v1] https://patchwork.ozlabs.org/project/uboot/patch/20260507090215.18074-1-chen.huei.lok@altera.com/
Chen Huei Lok (2):
drivers: clk: n5x: Fix incorrect EMAC clock source selection
drivers: clk: n5x: Use FIELD_GET for EMAC clock source selection
drivers/clk/altera/clk-n5x.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
--
2.43.7
More information about the U-Boot
mailing list