[U-Boot-Users] PATCH: Add command support for secondI2Ccontroller

[Ben Warren]

Nishanth,

Thanks for the feedback.  I agree completely with what you're saying.
Under no circumstances do we want to wreck existing implementations.
I'll go ahead and play with this a bit... At the very least we can work
switching of the ignore list into the set_bus command.

regards,
Ben

On Tue, 2006-05-16 at 12:15 -0500, Menon, Nishanth wrote:

> Hi Ben,
> > One sticky part is, how do we deal with the 'CFG_I2C_NOPROBE' stuff?
> In my board, I had ignored this.
> <snip>
> > structure that includes all bus information:
> > 
> > typedef struct _i2c_bus
> > {
> > 	int	baseAddress
> > 	int	busSpeed;
> > 	uchar	noProbeList[];
> > 	...  /* whatever else might be useful */
> > } i2c_bus;
> > 
> If we keep the following requirements:
> 1. We don't want to modify implementations of NOPROBE for all previous
> drivers
> 2. as less intrusive change as possible to cmd_i2c.c.
> 
> Two approaches appear to me:
> 1. use additional set_i2c_ignore cmd to select the ignore list/even make
> CFG_I2C_NOPROBES indexed on busses.
> +ve, minimal change to cmd_i2c.c,
> -ve - will be patch on..
> 
> 2. The structure defined as you gave it
> +ve - cleaner
> -ve - multiple changes to config files+ additional implementation to all
> legacy boards.
> 
> My view: I'd go with option 1. Primarily coz I suspect half our
> community might be too busy to go back and change and test all previous
> implementations.
> 
> Regards,
> Nishanth Menon
> 
> 
> -------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid0709&bid&3057&dat1642
> _______________________________________________
> U-Boot-Users mailing list
> U-Boot-Users at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.denx.de/pipermail/u-boot/attachments/20060516/20f80f9d/attachment.htm