[U-Boot] [PATCH] tools/mkimage: use lseek rather than fstat for file size for -l option

[Peter Korsgaard]

>>>>> "Wolfgang" == Wolfgang Denk <wd at denx.de> writes:

Hi,

 >> Exactly, hence my other patch (tools/mkimage: ignore trailing
 >> garbage) to only error out if the size is smaller than the size
 >> defined in the header.

 Wolfgang> This doesn't make sense to me. If we have a way to check
 Wolfgang> the image, we want to check everything, including correct
 Wolfgang> image length.

I provided a reason for the change in the patch:

"E.G. if the uImage was stored in flash and hence padded to the flash
sector size"

I can add a warning if there's trailing garbage if you prefer, but I
think the use case is valid.

 >> Ok, I kept it like that to keep the patch as minimal as possible -
 >> I'll change it and resend.

 Wolfgang> I think it makes little sense as my feeling is the changes make
 Wolfgang> mkimage checking not better, just worse.

Ok, fixed in the v2 patch I recently sent.

-- 
Bye, Peter Korsgaard