[U-Boot] [PATCH] net/net.c: correct timeout function

Wolfgang Denk wd at denx.de
Fri Dec 5 21:29:52 CET 2008


Dear Ben Warren,

In message <4938CECF.6090901 at gmail.com> you wrote:
> 
> > +static long net_get_timer(long base)
> > +{
> > +	return get_timer(base) / (CONFIG_SYS_HZ / 1000);
> > +}
> > +
> >   
> Please change this name to something more meaningful, maybe 
> get_timer_ms(). Apart from that, looks good. If you re-submit soon I'll 
> pull it in.

Please do not pull this. It just covers bugs elsewhere in the code.

We need to fix the real bugs, not put paint and wallpaper over it.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In accord with UNIX philosophy, Perl gives you enough  rope  to  hang
yourself.              - L. Wall & R. L. Schwartz, _Programming Perl_


More information about the U-Boot mailing list