[U-Boot] [PATCH] net/net.c: correct timeout function

Ben Warren biggerbadderben at gmail.com
Fri Dec 5 22:01:03 CET 2008


Wolfgang Denk wrote:
> Dear Ben Warren,
>
> In message <4938CECF.6090901 at gmail.com> you wrote:
>   
>>> +static long net_get_timer(long base)
>>> +{
>>> +	return get_timer(base) / (CONFIG_SYS_HZ / 1000);
>>> +}
>>> +
>>>   
>>>       
>> Please change this name to something more meaningful, maybe 
>> get_timer_ms(). Apart from that, looks good. If you re-submit soon I'll 
>> pull it in.
>>     
>
> Please do not pull this. It just covers bugs elsewhere in the code.
>
> We need to fix the real bugs, not put paint and wallpaper over it.
>
> Best regards,
>
> Wolfgang Denk
>
>   
OK


More information about the U-Boot mailing list