[U-Boot] [PATCH] IXP425: Improving print_cpuinfo code Part 1/1

Stefan Althoefer stefan.althoefer at web.de
Tue Dec 16 23:28:39 CET 2008


Jean-Christophe PLAGNIOL-VILLARD schrieb:
>> +	cfg_clk = *IXP425_EXP_CFG0 >> 21;
> please use readx/writex 

The pointer dereference style is used throughout the
other files in the IXP port as well. Shouldn't this
be handled the same way in all files?

>>  
>> +	/* FIXME: is there any need for the jiffies? */
> 	for the IRQ delay

Ok, I overlooked it is used in start.S.

-- Stefan




More information about the U-Boot mailing list