[U-Boot] [PATCH] IXP425: Improving print_cpuinfo code Part 1/1

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Wed Dec 17 00:18:04 CET 2008


On 23:28 Tue 16 Dec     , Stefan Althoefer wrote:
> Jean-Christophe PLAGNIOL-VILLARD schrieb:
> >> +	cfg_clk = *IXP425_EXP_CFG0 >> 21;
> > please use readx/writex 
> 
> The pointer dereference style is used throughout the
> other files in the IXP port as well. Shouldn't this
> be handled the same way in all files?
yes it's old wrong way code
for new we to use the good accessor

for old code patch are welcome

Best Regards,
J.


More information about the U-Boot mailing list