[U-Boot] EHCI last patch

michael trimarchi at gandalf.sssup.it
Wed Dec 17 14:08:08 CET 2008


Hi all,

Stefan Roese wrote:
> Hi Michael,
>
> On Friday 12 December 2008, michael wrote:
>   
>> In the last ehci patch I add myself in the author of the code. I'm not
>> sure if it possible. I change
>> the codes and test it but I don't know if the change are sufficient.
>>     
>
> You added yourself not as author but you added your Copyright. With all the 
> work you have done to this code lately I'm pretty sure that this is ok.
>
> Thanks for all your work on this. And please don't forget to add the EHCI-PCI 
> support as well.
>   
I have rewrite and clean the support for ehci-pci but I don't have any 
hardware to test on it. My
code is like this:

int ehci_hcd_init(void)
{
        pci_dev_t pdev;
        uint32_t addr;

        pdev = pci_find_devices(ehci_pci_ids, CONFIG_PCI_EHCI_DEVICE);
        if (dev == -1) {
                printf("EHCI host controller not found\n");
                return -1;
        }

        pci_read_config_dword(dev, PCI_BASE_ADDRESS_0, &addr);
        hccr = (struct ehci_hccr *)addr;
        hcor = (struct ehci_hcor *)((uint32_t) hccr +
                        HC_LENGTH(ehci_readl(&hccr->cr_capbase)));

        return 0;
}

and the CONFIG_PCI_EHCI_DEVICE. I notice that there is a table in 
usb_ohci too. Is there any
reason?

#ifdef CONFIG_PCI_EHCI_DEVICE
static struct pci_device_id ehci_pci_ids[] = {
        /* Please add supported PCI EHCI controller ids here */
        {0, 0}
};
#endif

It is very simple. The problem is thath currently I don't have any other 
hardware to test the code.
I have done some cleanup and I have the ixp4xx usb host support ready 
too. Are there people with ehci
hardware running u-boot?

Michael




More information about the U-Boot mailing list